Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add methods to allow customization of save dialog during will-download event #15497

Merged
merged 8 commits into from Nov 8, 2018
Merged

feat: add methods to allow customization of save dialog during will-download event #15497

merged 8 commits into from Nov 8, 2018

Commits on Nov 6, 2018

  1. feat: add method to DownloadItem that allows customization of dialog … 

    …options
    @brenca
    brenca committed Nov 6, 2018
    Copy the full SHA
    bb6de99 View commit details
    Browse the repository at this point in the history

  2. docs: add docs for get/setSaveDialogOptions

    @brenca
    brenca committed Nov 6, 2018
    Copy the full SHA
    8996b4b View commit details
    Browse the repository at this point in the history

  3. add missing copy constructor for DialogSettings on mac and linux

    @brenca
    brenca committed Nov 6, 2018
    Copy the full SHA
    8c6dc66 View commit details
    Browse the repository at this point in the history

  4. fix: don't filter dialog options for mas build, don't return properties

    @brenca
    brenca committed Nov 6, 2018
    Copy the full SHA
    537debd View commit details
    Browse the repository at this point in the history

  5. test: add test for get/setSaveDialogOptions

    @brenca
    brenca committed Nov 6, 2018
    Copy the full SHA
    4287bcc View commit details
    Browse the repository at this point in the history

  6. fix: remove openDevtools added for debugging

    @brenca
    brenca committed Nov 6, 2018
    Copy the full SHA
    ae042aa View commit details
    Browse the repository at this point in the history

  7. test: fix failing test because of new event parameter

    @brenca
    brenca committed Nov 6, 2018
    Copy the full SHA
    652afe6 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2018

  1. docs: use SaveDialogOptions instead of Object

    @brenca
    brenca committed Nov 7, 2018
    Copy the full SHA
    51a1c2c View commit details
    Browse the repository at this point in the history