Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow registering multiple shortcuts #15542

Merged
merged 7 commits into from Nov 7, 2018
Merged

feat: allow registering multiple shortcuts #15542

merged 7 commits into from Nov 7, 2018

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Nov 2, 2018 •
edited

Description of Change

This PR allows for multiple global shortcuts to be registered such that triggering any of them calls the same callback.

Ex.

const ret = globalShortcut.registerAll(['CmdOrCtrl+X', 'CmdOrCtrl+Y'], () => {
   console.log('did something!')
})

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Release Notes

Notes: allow registering of multiple globalShortcuts

@codebytere codebytere requested review from a team November 2, 2018 06:06
MarshallOfSound
MarshallOfSound requested changes Nov 2, 2018
View reviewed changes
docs/api/global-shortcut.md Outdated Show resolved Hide resolved
@codebytere codebytere added the semver/minor backwards-compatible functionality label Nov 2, 2018
@codebytere codebytere mentioned this pull request Nov 2, 2018
Closed
brenca
brenca approved these changes Nov 5, 2018
View reviewed changes
Copy link
Contributor

@brenca brenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@codebytere codebytere merged commit e9ba26f into master Nov 7, 2018
@release-clerk
Copy link

release-clerk bot commented Nov 7, 2018

Release Notes Persisted

allow registering of multiple globalShortcuts

@codebytere codebytere deleted the multiple-globals branch January 4, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brenca brenca brenca approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @brenca @MarshallOfSound