Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: no need for done call in sync tests #15550

Merged
merged 1 commit into from Nov 2, 2018
Merged

style: no need for done call in sync tests #15550

merged 1 commit into from Nov 2, 2018

Conversation

brenca
Copy link
Contributor

@brenca brenca commented Nov 2, 2018

Description of Change

As @MarshallOfSound suggested on #15401

Checklist

Release Notes

Notes: no-notes

@brenca brenca requested review from MarshallOfSound and a team November 2, 2018 13:45
@jkleinsc jkleinsc merged commit 1f5e0c4 into master Nov 2, 2018
@release-clerk
Copy link

release-clerk bot commented Nov 2, 2018 •
edited by ckerr

No Release Notes

@jkleinsc jkleinsc deleted the brenca/menu-test-remove-done branch November 2, 2018 14:50
@alexeykuzmin alexeykuzmin mentioned this pull request Nov 5, 2018
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brenca @ckerr @MarshallOfSound @jkleinsc