Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make feature strings more robust to whitespace #15602

Merged
merged 1 commit into from Nov 6, 2018

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Nov 6, 2018

Fixes #15594

The algorithm was already slightly lenient about whitespace, but surprisingly so. This makes it ignore all whitespace around , and = (and at beginning/end of the feature string).

Checklist

Release Notes

Notes: be more lenient about whitespace in webview's "webpreferences" feature string

@nornagon nornagon requested review from MarshallOfSound, a team and zcbenz November 6, 2018 19:48
@nornagon nornagon merged commit 10969b8 into master Nov 6, 2018
@release-clerk
Copy link

release-clerk bot commented Nov 6, 2018

Release Notes Persisted

be more lenient about whitespace in webview's "webpreferences" feature string

@nornagon nornagon deleted the robust-parse-features-string branch November 6, 2018 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants