fix: always disable setuid sandbox on linux #15722
Merged
+8
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
force-pushed
the
always-disable-setuid-sandbox
branch
from
d42ee54
to
34de1a5
Compare
deepak1556
approved these changes
Nov 15, 2018
codebytere
approved these changes
Nov 15, 2018
|
for upstream what? |
|
Merging because mac CI is broken. |
|
Release Notes Persisted
|
neo291
pushed a commit
to neo291/electron
that referenced
this pull request
Nov 16, 2018
neo291
pushed a commit
to neo291/electron
that referenced
this pull request
Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Previously, when
--enable-mixed-sandboxwas passed, the setuid sandbox would not be disabled. In other places in the code we assume that the setuid sandbox is not in use.Checklist
npm testpassesRelease Notes
Notes: fix an issue where on Linux, the setuid sandbox was incorrectly enabled when passing
--enable-mixed-sandbox