feat: promisify win.capturePage() #15743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitsakh
reviewed
Nov 16, 2018
|
This should go through our deprecation cycle right? We should probably add a JS side wrapper so that callback-style still works but with a deprecation warning |
codebytere
changed the title
codebytere
force-pushed
the
promisify-capturePage
branch
from
1020f35
to
5c5286b
Compare
codebytere
force-pushed
the
promisify-capturePage
branch
from
d2bf372
to
7063cd9
Compare
|
@MarshallOfSound rebased and updated! |
| [NativeImage](native-image.md) that stores data of the snapshot. Omitting | ||
| `rect` will capture the whole visible page. | ||
| be called with `callback(image)`. The `image` is an instance of [NativeImage](native-image.md) | ||
| that stores data of the snapshot. Omitting `rect` will capture the whole visible page. |
There was a problem hiding this comment.
that stores data of the snapshot could be clearer, but that's the only thing I could find with this PR. The rest looks ✨ and it's honestly a nit.
felixrieseberg
approved these changes
Nov 27, 2018
codebytere
force-pushed
the
promisify-capturePage
branch
from
d2e7de2
to
848defd
Compare
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR promisifies
win.capturePage.Todo:
/cc @ckerr @deepak1556
Checklist
npm testpassesRelease Notes
Notes: promisify win.capturePage()
Co-authored-by: Charles Kerr ckerr@github.com