fix: switch to mojo proxy resolver (3-1-x) #15813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
force-pushed
the
backport_14656_mojo_proxy_resolver
branch
from
db9e360
to
47c9ab1
Compare
deepak1556
force-pushed
the
backport_14656_mojo_proxy_resolver
branch
from
0608c39
to
1001f26
Compare
deepak1556
force-pushed
the
backport_14656_mojo_proxy_resolver
branch
from
1001f26
to
9a9b382
Compare
deepak1556
force-pushed
the
backport_14656_mojo_proxy_resolver
branch
from
9a9b382
to
830c57b
Compare
|
@deepak1556 I'll go ahead and rebase this onto |
|
@felixrieseberg thanks! |
felixrieseberg
approved these changes
Nov 26, 2018
codebytere
approved these changes
Nov 26, 2018
jkleinsc
changed the title
|
CircleCI is failing on the login item API, which is a known flake. Merging. |
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The first commit is direct backport with only gyp specific changes, the second commit gets the patches made in libcc and the last commit updates api for Chromium 66 since the original PR was agains Chromium 69.
Backports #14656
Depends on electron/libchromiumcontent#705
Fixes #13829
Checklist
npm testpassesRelease Notes
Notes: Switch to mojo proxy resolver