Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use appropriate site instance for cross-site nav's #15821

Merged
merged 19 commits into from Dec 5, 2018
Merged

fix: use appropriate site instance for cross-site nav's #15821

merged 19 commits into from Dec 5, 2018

Commits on Dec 4, 2018

  1. fix: use Chromium's determined new site instance as candidate when na… 

    …vigating.

When navigating to a new address, consider using Chromium's determined site instance
for the new page as it should belong to an existing browsing instance when the
navigation was triggered by window.open().

fixes 8100.
    @ppontes
    ppontes committed Dec 4, 2018
    Copy the full SHA
    cb2d31c View commit details
    Browse the repository at this point in the history

  2. Revert "fix: use Chromium's determined new site instance as candidate… 

    … when navigating."

This reverts commit eb95f93.
    @ppontes
    ppontes committed Dec 4, 2018
    Copy the full SHA
    7530af6 View commit details
    Browse the repository at this point in the history

  3. fix: delegate site instance creation back to content when sandboxed.

    @ppontes
    ppontes committed Dec 4, 2018
    Copy the full SHA
    6e03731 View commit details
    Browse the repository at this point in the history

  4. fix: ensure site isolation is on

    @ppontes
    ppontes committed Dec 4, 2018
    Copy the full SHA
    694e51b View commit details
    Browse the repository at this point in the history

  5. test: adapt ut for cross-site navigation

    @ppontes
    ppontes committed Dec 4, 2018
    Copy the full SHA
    bd857e9 View commit details
    Browse the repository at this point in the history

  6. fix: register pending processes during a navigation.

    @ppontes
    ppontes committed Dec 4, 2018
    Copy the full SHA
    e799fe0 View commit details
    Browse the repository at this point in the history

  7. refactor: dont call loadURL for a window constructed from an existing… 

    … webContents.
    @ppontes
    ppontes committed Dec 4, 2018
    Copy the full SHA
    9271a39 View commit details
    Browse the repository at this point in the history

  8. test: add sandboxed affinity UT's.

    @ppontes
    ppontes committed Dec 4, 2018
    Copy the full SHA
    5aae695 View commit details
    Browse the repository at this point in the history

  9. fix: check affinity before deciding if to force a new site instance.

    @ppontes
    ppontes committed Dec 4, 2018
    Copy the full SHA
    2225c0b View commit details
    Browse the repository at this point in the history

  10. chore: adapt subsequent patch.

    @ppontes
    ppontes committed Dec 4, 2018
    Copy the full SHA
    6d02359 View commit details
    Browse the repository at this point in the history

  11. refactor: constify logically const methods.

    @ppontes
    ppontes committed Dec 4, 2018
    Copy the full SHA
    f85ad5c View commit details
    Browse the repository at this point in the history

  12. fix: do not reuse site instances when navigation redirects cross-site.

    @ppontes
    ppontes committed Dec 4, 2018
    Copy the full SHA
    220b722 View commit details
    Browse the repository at this point in the history

  13. test: ensure localStorage accessible after x-site redirect.

    @ppontes
    ppontes committed Dec 4, 2018
    Copy the full SHA
    f4e3036 View commit details
    Browse the repository at this point in the history

  14. test: adapt localStorage acess denied UT for site isolation.

    @ppontes
    ppontes committed Dec 4, 2018
    Copy the full SHA
    c30f003 View commit details
    Browse the repository at this point in the history

  15. fix: do not send render-view-deleted for speculative frames.

    @ppontes
    ppontes committed Dec 4, 2018
    Copy the full SHA
    d8d16a5 View commit details
    Browse the repository at this point in the history

  16. chore: amend tests after rebase.

    @ppontes
    ppontes committed Dec 4, 2018
    Copy the full SHA
    9829b19 View commit details
    Browse the repository at this point in the history

  17. test: add ut for webContents' render-view-deleted emission

    @ppontes
    ppontes committed Dec 4, 2018
    Copy the full SHA
    c56311f View commit details
    Browse the repository at this point in the history

  18. fix: introduce current-render-view-deleted for current RVH's deletions. 

    Revert render-view-deleted to being emitted with any RVH's deletion.
current-render-view-deleted is emitted only when the RVH being deleted
is the current one.
    @ppontes
    ppontes committed Dec 4, 2018
    Copy the full SHA
    14daf67 View commit details
    Browse the repository at this point in the history

  19. refactor: style and comments fixed.

    @ppontes
    ppontes committed Dec 4, 2018
    Copy the full SHA
    8b4e030 View commit details
    Browse the repository at this point in the history