Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: webContents.loadURL returns a promise #15855

Merged
merged 7 commits into from Dec 6, 2018
Merged

feat: webContents.loadURL returns a promise #15855

merged 7 commits into from Dec 6, 2018

Commits on Dec 3, 2018

  1. feat: webContents.loadURL returns a promise

    @nornagon
    nornagon committed Dec 3, 2018
    Copy the full SHA
    8894125 View commit details
    Browse the repository at this point in the history

  2. silence unhandled rejection

    @nornagon
    nornagon committed Dec 3, 2018
    Copy the full SHA
    0a7a1af View commit details
    Browse the repository at this point in the history

  3. remove unhandledrejection event after test is done

    @nornagon
    nornagon committed Dec 3, 2018
    Copy the full SHA
    64c31c9 View commit details
    Browse the repository at this point in the history

  4. fix validated file url on win32

    @nornagon
    nornagon committed Dec 3, 2018
    Copy the full SHA
    dad43e5 View commit details
    Browse the repository at this point in the history

  5. reject the promise if the navigation is aborted

    @nornagon
    nornagon committed Dec 3, 2018
    Copy the full SHA
    b1cd3e0 View commit details
    Browse the repository at this point in the history

  6. more tests

    @nornagon
    nornagon committed Dec 3, 2018
    Copy the full SHA
    3f36220 View commit details
    Browse the repository at this point in the history

  7. narrow promise type

    @nornagon
    nornagon committed Dec 3, 2018
    Copy the full SHA
    886aefc View commit details
    Browse the repository at this point in the history