test: fix a bunch of flaky tests related to emittedOnce #15871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
approved these changes
Nov 29, 2018
|
No Release Notes |
|
/trop run backport |
|
The backport process for this PR has been manually initiated, here we go! :D |
|
I was unable to backport this PR to "4-0-x" cleanly; |
|
@nornagon Can you please create a backport it to |
nornagon
added a commit
that referenced
this pull request
Nov 29, 2018
This was referenced Nov 29, 2018
codebytere
pushed a commit
that referenced
this pull request
Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
It seems that a common source of test flake is events firing before listeners are registered, in particular with
loadURLanddid-finish-load. It's not clear to me how those events could be getting fired early, but they are, and this fixes it, hopefully.Relatedly: #15855
Checklist
Release Notes
Notes: no-notes