Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore ability to disable color correct rendering (superseded) #15893

Closed
wants to merge 1 commit into from

Commits on Nov 29, 2018

  1. fix: restore ability to disable color correct rendering

    In Electron 2.0, `--disable-features=ColorCorrectRendering` could be
    used to make the app use the display color space (e.g. P3 on Macs)
    instead of color correcting to sRGB. Because color correct rendering is
    always enabled on Chromium 62 and later and because
    `--force-color-profile` has no effect on macOS, apps that need e.g. P3
    colors are currently stuck on Electron 2.0.
    
    This restores the functionality removed in
    https://chromium-review.googlesource.com/698347 in the form of the
    `--disable-color-correct-rendering` switch.
    
    This can be removed once web content (including WebGL) learn how
    to deal with color spaces. That is being tracked at
    https://crbug.com/634542 and https://crbug.com/711107.
    
    As an example of a widely used app using
    `--disable-features=ColorCorrectRendering`, see VSCode:
    https://github.com/Microsoft/vscode/blob/3f33ef2593d3efe6eca5230f3d34d3406fb73498/src/main.js#L138-L139
    
    Notes: Add `--disable-color-correct-rendering` switch
    poiru committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    527aa2a View commit details
    Browse the repository at this point in the history