feat: allow immediate MacOS notifications #16060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
changed the title
codebytere
changed the title
nornagon
requested changes
Dec 14, 2018
Co-Authored-By: codebytere <codebytere@github.com>
ckerr
reviewed
Dec 14, 2018
ckerr
approved these changes
Dec 14, 2018
nornagon
approved these changes
Dec 14, 2018
|
Release Notes Persisted
|
|
Hey @codebytere, the release notes here are confusing because "notification" sounds like it means Notification. Can you edit @release-clerk's notes and clarify? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Resolves #15789.
Refactors notification posting on MacOS to allow for some notifications to deliver immediately regardless of whether or not the subscribing app is active or not.
Only
NSDistributedNotificationCenterhas access to thedeliverImmediateselector, so I split out theDoPostNotificationhelper into the calling functions as it now make more sense for each to just call the methods themselves rather than call out to a helper.deliverImmediatewas also added as an optional new param so as to maintain backwards compat./cc @ckerr
Checklist
npm testpassesRelease Notes
Notes: allow for MacOS notifications to be immediately delivered