Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make nugget quiet by default #16147

Merged
merged 2 commits into from Dec 20, 2018
Merged

chore: make nugget quiet by default #16147

merged 2 commits into from Dec 20, 2018

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Dec 19, 2018

Description of Change

nugget's output is useful when the release script is being run by humans, but now that Sudowoodo handles releases its output clogs Papertrail and makes it harder to spot more prescient errors. This PR this makes nugget quiet unless --verboseNugget is passed.

/cc @jkleinsc

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines
  • PR release notes describe the change in a way relevant to app-developers

Release Notes

Notes: no-notes

@codebytere codebytere requested a review from a team December 19, 2018 16:03
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of removing the option to set quiet, I'd prefer that quiet could be turned off or on from a command line argument. I'm fine if it defaults to quiet but if someone is manually finishing a release, they might want the more verbose output.

@codebytere
Copy link
Member Author

lint failure fixed by: #16153.

@codebytere codebytere merged commit 90d314c into master Dec 20, 2018
@release-clerk
Copy link

release-clerk bot commented Dec 20, 2018

No Release Notes

@codebytere
Copy link
Member Author

/trop run backport-to 4-0-x,3-1-x,3-0-x

@trop
Copy link
Contributor

trop bot commented Dec 20, 2018

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "4-0-x" here we go! :D

@codebytere codebytere deleted the quiet-nugget branch December 20, 2018 03:36
@trop
Copy link
Contributor

trop bot commented Dec 20, 2018

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "3-1-x" here we go! :D

@trop
Copy link
Contributor

trop bot commented Dec 20, 2018

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "3-0-x" here we go! :D

@trop
Copy link
Contributor

trop bot commented Dec 20, 2018

I have automatically backported this PR to "4-0-x", please check out #16154

@trop
Copy link
Contributor

trop bot commented Dec 20, 2018

I was unable to backport this PR to "3-1-x" cleanly;
you will need to perform this backport manually.

@trop trop bot added the in-flight/4-0-x label Dec 20, 2018
@trop
Copy link
Contributor

trop bot commented Dec 20, 2018

I was unable to backport this PR to "3-0-x" cleanly;
you will need to perform this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants