feat: flexible autoresize for BrowserViews #16184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
summeroff
force-pushed
the
sl_browser_view_autoresize_master
branch
from
6dce162
to
6ef9b13
Compare
zcbenz
force-pushed
the
sl_browser_view_autoresize_master
branch
2 times, most recently
from
47c040b
to
73397b1
Compare
zcbenz
force-pushed
the
sl_browser_view_autoresize_master
branch
from
73397b1
to
614b05a
Compare
zcbenz
approved these changes
Jan 31, 2019
|
Release Notes Persisted
|
summeroff
added a commit
to stream-labs/electron
that referenced
this pull request
Apr 22, 2019
* feat: flexible autoresize for BrowserViews * fix: change to static_cast * Slight format code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flexible autoresize for BrowserViews in BrowserWindow
As support for multy BrowserView in BrowserWIndow added in PR #16148. How current autoresize options work is not always suitable to what app developer can need when some browser views resize together. It is because
widthandheightautoresize modes change view by same amount what windows changed.This commit add two new options
horizontalandvertical. With this options enabled, a browserview will autoresize not only dimensions but position on window too. And in a way that keep proportions the same.For example we add two views.
view1 x:100 width:100andview2 x:200 width:200in window with width 400.And if user change window width to 800 then autoresize updates views to
view1 x:200 width:200andview2 x:400 width:400Checklist
npm testpassesRelease Notes
Notes: Added flexible autoresize option for
BrowserViews inBrowserWindow.