docs: Show the code of adding devtools extension #16186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zcbenz Can you take a look? I'm not sure why the tests are failing. I changed only the docs. Thanks! |
zcbenz
requested changes
Dec 25, 2018
|
The failing tests are not related to this PR, they can be ignored. |
|
Thanks @zcbenz ! |
miniak
requested changes
Jan 8, 2019
moshfeu
added a commit
to moshfeu/electron
that referenced
this pull request
Jan 8, 2019
|
@miniak Done. I think that the fail tests is not related to my change. |
|
@zcbenz can you take a look please? |
zcbenz
force-pushed
the
update-devtools-extension-doc
branch
from
ac2a506
to
4699d83
Compare
zcbenz
approved these changes
Jan 15, 2019
|
Release Notes Persisted
|
akisctx
pushed a commit
to akisctx/electron
that referenced
this pull request
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Just to show the path is not enough because it's not working - nodejs/node#684 (comment).
Replaced with a working code.
Checklist
and stakeholders cc'dI don't know who they are)Release Notes
Notes: adding devtools extension docs improvement