Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get foreground color from GtkMenuBar#menubar (3-0-x) #16221

Merged

Conversation

Cobinja
Copy link

@Cobinja Cobinja commented Dec 31, 2018

Description of Change

Backport of #15878 to 3-0-x
Depends on electron/libchromiumcontent#741
/cc @inukshuk

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: Fixes incorrect foreground color on GTK menubar

@Cobinja Cobinja requested a review from a team December 31, 2018 12:54
@welcome
Copy link

welcome bot commented Dec 31, 2018

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@Cobinja Cobinja changed the title fix: get background color from GtkMenuBar#menubar (3-0-x) fix: get foreground color from GtkMenuBar#menubar (3-0-x) Dec 31, 2018
@codebytere
Copy link
Member

Just need to wait for #16245, then we'll get this merged!

@codebytere codebytere merged commit 7ba4321 into electron:3-0-x Jan 3, 2019
@release-clerk
Copy link

release-clerk bot commented Jan 3, 2019

Release Notes Persisted

Fixes incorrect foreground color on GTK menubar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants