Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get foreground color from GtkMenuBar#menubar (3-1-x) #16222

Merged

Conversation

Cobinja
Copy link

@Cobinja Cobinja commented Dec 31, 2018

Description of Change

Backport of #15878 to 3-1-x
Depends on electron/libchromiumcontent#742
/cc @inukshuk

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: Fixed incorrect foreground color on GTK menubar.

@Cobinja Cobinja requested a review from a team December 31, 2018 12:57
@Cobinja Cobinja changed the title fix: get background color from GtkMenuBar#menubar (3-1-x) fix: get foreground color from GtkMenuBar#menubar (3-1-x) Dec 31, 2018
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving pending merge of #16331

@codebytere codebytere merged commit 55e9c21 into electron:3-1-x Jan 10, 2019
@release-clerk
Copy link

release-clerk bot commented Jan 10, 2019

Release Notes Persisted

Fixed incorrect foreground color on GTK menubar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants