fix: add default media usage strings to info.plist #16240
Conversation
| <key>NSCameraUsageDescription</key> | ||
| <string></string> | ||
| <string>This app needs access to the camera</string> |
There was a problem hiding this comment.
Can you share a screenshot of what the dialog looks like with this text?
|
@nornagon it'd look just like this:
|
|
Then where does the string you just added go? |
|
Given that the modal doesn't have the app name in the title bar, I'm concerned that the "This app" wording is ambiguous... but don't have a good thought on how to improve it. 🤔 |
|
The wording doesn't even seem to show up in the dialog, so i'm confused why this is needed at all :/ perhaps we can get some clarification on the original issue as to what the problem is? |
|
@nornagon I'm not 100% sure but I'm fairly certain the text shows up where the existing text is in the dialog @codebytere shared. |
|
@codebytere shared this screenshot with me, which she took with this patch applied. |
|
though... wait a sec... why does that say |
|
Okay, it looks like this string shows up as additional context: (which negates my concern about the "this" wording) |
|
I don't 100% trust that the mac docs line up with what we're doing here. I don't have mojave, so can't test this right now, but someone really just needs to actually apply this patch and run it on their own machine to test. I thought @codebytere did that but now i'm confused by the |
|
@nornagon i had chrome open in the background and took the screenshot while i was scrolled down to #15624 (comment). |
|
Do we think we should try to merge this? |
Description of Change
This PR adds default keys to Info.plist for
NSMicrophoneUsageDescriptionandNSCameraUsageDescription. This will simplify usage of the media access apis added for MacOS Mojave./cc @nornagon @miniak
Checklist
npm testpassesRelease Notes
Notes: Added default
NSMicrophoneUsageDescriptionandNSCameraUsageDescriptionkeys to Info.plist.