New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose systemPreferences.getSystemColor() #16248
Conversation
Seeing very weird error on mac builds; it builds fine locally 🤔
|
b8f3b3b
to
208ea1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 ✅
0be9257
to
58cc6f2
Compare
Release Notes Persisted
|
@codebytere Out of curiosity:
I can't seem to find this anywhere, did you have a chance to work on it? UPDATE: Nevermind, found it! Thanks for the work! |
Description of Change
Partially resolves #16246. There will be a second follow-up PR that adds MacOS support for Dynamic Colors to the existing
systemPreferences.getColor()
method that already exists for Windows.Checklist
npm test
passesRelease Notes
Notes: Add a way to query for system colors on MacOS via
systemPreferences.getSystemColor()
.