Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose systemPreferences.getSystemColor() #16248

Merged
merged 1 commit into from Jan 3, 2019
Merged

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Jan 3, 2019

Description of Change

Partially resolves #16246. There will be a second follow-up PR that adds MacOS support for Dynamic Colors to the existing systemPreferences.getColor() method that already exists for Windows.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines
  • PR release notes describe the change in a way relevant to app-developers

Release Notes

Notes: Add a way to query for system colors on MacOS via systemPreferences.getSystemColor().

@codebytere codebytere requested review from a team January 3, 2019 05:59
@codebytere codebytere changed the title feat: expose systemPreferences.getSystemColor() for MacOS feat: expose systemPreferences.getSystemColor() Jan 3, 2019
@codebytere
Copy link
Member Author

codebytere commented Jan 3, 2019

Seeing very weird error on mac builds; it builds fine locally 🤔

../../electron/atom/browser/api/atom_api_system_preferences_mac.mm:386:27: error: class method '+systemBlueColor' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]
           sysColor = [NSColor systemBlueColor];

Copy link
Contributor

@BinaryMuse BinaryMuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 ✅

@release-clerk
Copy link

release-clerk bot commented Jan 3, 2019

Release Notes Persisted

Add a way to query for system colors on MacOS via systemPreferences.getSystemColor().

@codebytere codebytere deleted the add-system-color branch January 3, 2019 22:30
akisctx pushed a commit to akisctx/electron that referenced this pull request Jan 22, 2019
@oskarkrawczyk
Copy link

oskarkrawczyk commented Feb 12, 2019

@codebytere Out of curiosity:

There will be a second follow-up PR that adds MacOS support for Dynamic Colors

I can't seem to find this anywhere, did you have a chance to work on it?

UPDATE: Nevermind, found it! Thanks for the work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

system color API for macOS
4 participants