Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add mac support to systemPrefs.getColor() #16249

Merged
merged 1 commit into from Jan 4, 2019
Merged

feat: add mac support to systemPrefs.getColor() #16249

merged 1 commit into from Jan 4, 2019

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Jan 3, 2019 •
edited by BinaryMuse

Description of Change

Resolves #16246. Adds MacOS support to systemPreferences.getColor().

TODO

  • documentation updates
  • @available wrapping around newer apis

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines
  • PR release notes describe the change in a way relevant to app-developers

Release Notes

Notes: Added macOS support to systemPreferences.getColor().

@codebytere codebytere requested a review from a team January 3, 2019 07:15
@codebytere codebytere requested a review from a team January 3, 2019 16:44
@codebytere codebytere changed the title [wip] feat: add mac support to systemPrefs.getColor() feat: add mac support to systemPrefs.getColor() Jan 3, 2019
@codebytere codebytere force-pushed the add-mac-color-support branch 2 times, most recently from b9de800 to dcc47c3 Compare January 3, 2019 17:14
BinaryMuse
BinaryMuse approved these changes Jan 3, 2019
View reviewed changes
Copy link
Contributor

@BinaryMuse BinaryMuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor docs change otherwise 📝 ✅

docs/api/system-preferences.md Show resolved Hide resolved
@codebytere codebytere force-pushed the add-mac-color-support branch 2 times, most recently from 552c7be to 4d1738e Compare January 3, 2019 22:51
@codebytere codebytere merged commit b57046e into master Jan 4, 2019
@release-clerk
Copy link

release-clerk bot commented Jan 4, 2019

Release Notes Persisted

Added macOS support to systemPreferences.getColor().

@codebytere codebytere deleted the add-mac-color-support branch January 4, 2019 00:17
akisctx pushed a commit to akisctx/electron that referenced this pull request Jan 22, 2019
@codebytere @akisctx
feat: add mac support to systemPrefs.getColor() (electron#16249)
e82bb0b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BinaryMuse BinaryMuse BinaryMuse approved these changes

@miniak miniak miniak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @BinaryMuse @miniak