Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error if a11y support changed before ready #16261

Merged
merged 1 commit into from Jan 4, 2019
Merged

Conversation

codebytere
Copy link
Member

Description of Change

Resolves #16256.

Starting with v4.0.0, app.setAccessibilitySupportEnabled() can only be called after the ready event is emitted. This clarifies that in documentation and ensures that an error is thrown so the method does not crash.

/cc @deepak1556

Checklist

Release Notes

Notes: Throw an error if app.setAccessibilitySupportEnabled() is called before the ready event is emitted.

@codebytere codebytere requested review from a team January 4, 2019 03:05
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkleinsc
Copy link
Contributor

jkleinsc commented Jan 4, 2019

Merging as arm failure is unrelated to change (and broken in master).

@jkleinsc jkleinsc merged commit de0e473 into master Jan 4, 2019
@release-clerk
Copy link

release-clerk bot commented Jan 4, 2019

Release Notes Persisted

Throw an error if app.setAccessibilitySupportEnabled() is called before the ready event is emitted.

@trop
Copy link
Contributor

trop bot commented Jan 4, 2019

I have automatically backported this PR to "4-0-x", please check out #16268

@jkleinsc jkleinsc deleted the a11y-ready-warning branch January 4, 2019 15:23
akisctx pushed a commit to akisctx/electron that referenced this pull request Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants