Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't register some shortcuts without accessibility #16276

Merged
merged 1 commit into from Jan 12, 2019
Merged

fix: don't register some shortcuts without accessibility #16276

merged 1 commit into from Jan 12, 2019

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Jan 4, 2019 •
edited

Description of Change

Backports #16125 to 3-1-x. Also partially backports #16119, as it's required for the fix impl.

See those PRs for more details.

Checklist

Release Notes

Notes: Fixed crash on macOS when using globalShortcut for media keys when accessibility access is not granted.

@codebytere codebytere requested review from a team January 4, 2019 19:34
@miniak
Copy link
Contributor

miniak commented Jan 5, 2019 

../../atom/browser/api/atom_api_global_shortcut.cc:28:18: error: no member named 'IsAtLeastOS10_14' in namespace 'base::mac'
  if (base::mac::IsAtLeastOS10_14()) {

@codebytere
Copy link
Member Author

yeah @miniak i think that version of chrome doesn't have that method

@nornagon
Copy link
Member

nornagon commented Jan 8, 2019

The PR description says "backports to 4-0-x" but it looks like the target is 3-1-x?

miniak
miniak requested changes Jan 11, 2019
View reviewed changes
atom/common/platform_util_mac.mm Outdated Show resolved Hide resolved
atom/common/platform_util_mac.mm Outdated Show resolved Hide resolved
miniak
miniak requested changes Jan 11, 2019
View reviewed changes
atom/common/platform_util_mac.mm Outdated Show resolved Hide resolved
ckerr
ckerr approved these changes Jan 11, 2019
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs approve

@codebytere codebytere merged commit 8f629a2 into 3-1-x Jan 12, 2019
@release-clerk
Copy link

release-clerk bot commented Jan 12, 2019

Release Notes Persisted

Fixed crash on macOS when using globalShortcut for media keys when accessibility access is not granted.

@codebytere codebytere deleted the shortcut-bp-3-1 branch January 12, 2019 18:30
@trop trop bot mentioned this pull request Jan 12, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Jan 12, 2019

I have automatically backported this PR to "3-0-x", please check out #16378

@sofianguy sofianguy added this to Fixed in 3.1.1 in 3.1.x Jan 25, 2019
@sofianguy sofianguy added this to Fixed (3.0.15) in 3.0.x / 3.1.x Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@miniak miniak miniak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
3.0.x / 3.1.x
Fixed (3.0.15)
3.1.x
Fixed in 3.1.1
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@codebytere @miniak @nornagon @ckerr