feat: add app.commandLine.hasSwitch() / app.commandLine.getSwitchValue() #16282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniak
requested review from
a team,
nornagon,
MarshallOfSound,
codebytere,
deepak1556 and
felixrieseberg
miniak
force-pushed
the
miniak/commandline-api
branch
from
4e9e90a
to
d9418fb
Compare
miniak
force-pushed
the
miniak/commandline-api
branch
from
d9418fb
to
c2de926
Compare
miniak
force-pushed
the
miniak/commandline-api
branch
from
c2de926
to
7983527
Compare
miniak
force-pushed
the
miniak/commandline-api
branch
from
7983527
to
cd5f1c4
Compare
alexeykuzmin
reviewed
Jan 7, 2019
|
|
||
| Returns `String` - The command-line switch value. | ||
|
|
||
| **Note:** When the switch is not present, it returns empty string. |
There was a problem hiding this comment.
that's how the chromium API behaves
alexeykuzmin
reviewed
Jan 7, 2019
alexeykuzmin
suggested changes
Jan 7, 2019
alexeykuzmin
approved these changes
Jan 7, 2019
codebytere
approved these changes
Jan 7, 2019
|
Release Notes Persisted
|
akisctx
pushed a commit
to akisctx/electron
that referenced
this pull request
Jan 22, 2019
…e() (electron#16282) * feat: add app.commandLine.hasSwitch() / app.commandLine.getSwitchValue() * add more tests * refactor: move appendSwitch / appendArgument to command_line module * replace AppendSwitchASCII with AppendSwitchNative * remove castArgs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Expose the following APIs, which we are already using internally in lib/renderer/init.js
app.commandLine.hasSwitch()app.commandLine.getSwitchValue()These methods are useful for parsing command-line options in robust way without having to use external libraries.
Checklist
npm testpassesRelease Notes
Notes: Added
app.commandLine.hasSwitch()/app.commandLine.getSwitchValue()