Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use default-app behavior in packaged apps #16310

Merged
merged 1 commit into from Jan 15, 2019
Merged

feat: use default-app behavior in packaged apps #16310

merged 1 commit into from Jan 15, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jan 7, 2019 •
edited

Description of Change

unify the behavior between default app and packaged apps:

  • create default application menu unless the app has one
  • default window-all-closed handling unless the app handles the event

Checklist

Release Notes

Notes: Unified behavior between the default app and packaged apps (application menu / window-all-closed handling)

@miniak miniak added the wip ⚒ label Jan 7, 2019
@miniak miniak self-assigned this Jan 7, 2019
@miniak miniak requested review from a team January 7, 2019 21:23
@miniak miniak changed the title feat: use default-app behavior in packaged apps (default menu / window-all-closed handling feat: use default-app behavior in packaged apps Jan 7, 2019
@miniak miniak force-pushed the miniak/default-app-behavior branch from 9a27ad8 to ae6480a Compare January 7, 2019 21:24
@codebytere codebytere changed the title feat: use default-app behavior in packaged apps [wip] feat: use default-app behavior in packaged apps Jan 7, 2019
@miniak miniak force-pushed the miniak/default-app-behavior branch from ae6480a to 548b7bf Compare January 7, 2019 22:18
MarshallOfSound
MarshallOfSound reviewed Jan 7, 2019
View reviewed changes
lib/browser/init.js Outdated Show resolved Hide resolved
@miniak miniak force-pushed the miniak/default-app-behavior branch 5 times, most recently from 2ef3347 to 7a716c7 Compare January 8, 2019 19:09
@miniak miniak removed the wip ⚒ label Jan 8, 2019
@miniak miniak changed the title [wip] feat: use default-app behavior in packaged apps feat: use default-app behavior in packaged apps Jan 8, 2019
@miniak miniak force-pushed the miniak/default-app-behavior branch from 7a716c7 to 0e6bde1 Compare January 8, 2019 20:05
@miniak miniak added the wip ⚒ label Jan 8, 2019
@miniak miniak changed the title feat: use default-app behavior in packaged apps [wip] feat: use default-app behavior in packaged apps Jan 8, 2019
@miniak miniak force-pushed the miniak/default-app-behavior branch 4 times, most recently from cfb5345 to 50e9528 Compare January 10, 2019 15:16
@miniak miniak changed the title [wip] feat: use default-app behavior in packaged apps feat: use default-app behavior in packaged apps Jan 10, 2019
@miniak miniak removed the wip ⚒ label Jan 10, 2019
@miniak miniak force-pushed the miniak/default-app-behavior branch from 50e9528 to f908d88 Compare January 10, 2019 15:21
@miniak miniak force-pushed the miniak/default-app-behavior branch from f908d88 to cfb5345 Compare January 10, 2019 15:25
alexeykuzmin
alexeykuzmin reviewed Jan 10, 2019
View reviewed changes
docs/api/menu.md Outdated Show resolved Hide resolved
@miniak miniak force-pushed the miniak/default-app-behavior branch 3 times, most recently from 32d564e to cbe5a16 Compare January 13, 2019 21:24
nornagon
nornagon requested changes Jan 14, 2019
View reviewed changes
docs/api/process.md Outdated Show resolved Hide resolved
docs/api/menu.md Outdated Show resolved Hide resolved
docs/api/menu.md Outdated Show resolved Hide resolved
lib/browser/init.js Outdated Show resolved Hide resolved
default_app/main.js Show resolved Hide resolved
spec/fixtures/api/default-menu/main.js Outdated Show resolved Hide resolved
@miniak miniak force-pushed the miniak/default-app-behavior branch 2 times, most recently from 001b989 to 82a6ac8 Compare January 14, 2019 23:47
nornagon
nornagon reviewed Jan 14, 2019
View reviewed changes
docs/api/menu.md Outdated Show resolved Hide resolved
@miniak miniak force-pushed the miniak/default-app-behavior branch from 82a6ac8 to 6d8576c Compare January 14, 2019 23:58
@miniak miniak removed the request for review from ckerr January 15, 2019 09:13
@miniak miniak force-pushed the miniak/default-app-behavior branch from 6d8576c to a2fec4b Compare January 15, 2019 15:55
@alexeykuzmin
Copy link
Contributor

@electron/docs can you please review this?

@alexeykuzmin alexeykuzmin merged commit 23d44e3 into master Jan 15, 2019
@release-clerk
Copy link

release-clerk bot commented Jan 15, 2019

Release Notes Persisted

Unified behavior between the default app and packaged apps (application menu / window-all-closed handling)

@alexeykuzmin alexeykuzmin deleted the miniak/default-app-behavior branch January 15, 2019 20:36
akisctx pushed a commit to akisctx/electron that referenced this pull request Jan 22, 2019
@miniak @akisctx
feat: use default-app behavior in packaged apps (electron#16310)
34109c6 
Unify the behavior between default app and packaged apps:
- create default application menu unless the app has one
- default window-all-closed handling unless the app handles the event
@erickzhao erickzhao mentioned this pull request May 4, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus left review comments

@nornagon nornagon nornagon approved these changes

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

@codebytere codebytere codebytere approved these changes

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

@deepak1556 deepak1556 Awaiting requested review from deepak1556

Assignees

@miniak miniak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@miniak @alexeykuzmin @sindresorhus @nornagon @codebytere @MarshallOfSound