fix: beep on Ubuntu #16350
Merged
fix: beep on Ubuntu #16350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beeps on Linux are made by writing BEL to /dev/console, which requires elevated permissions on Ubuntu. So if opening /dev/console fails, fall back to /dev/tty.
|
|
BinaryMuse
approved these changes
Jan 10, 2019
codebytere
approved these changes
Jan 10, 2019
|
Release Notes Persisted
|
|
I have automatically backported this PR to "4-0-x", please check out #16357 |
akisctx
pushed a commit
to akisctx/electron
that referenced
this pull request
Jan 22, 2019
beeps on Linux are made by writing BEL to /dev/console, which requires elevated permissions on Ubuntu. So if opening /dev/console fails, fall back to /dev/tty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The
shell.beep()implementation for Linux works by writing BEL to/dev/console. However,/dev/consolerequires elevated permissions on Ubuntu. So if opening/dev/consolefails, use/dev/ttyas a fallback.There's no particular stakeholder for this, but CC'ing @BinaryMuse as she was participating in the Linux Beep discussion earlier
Checklist
npm testpassesRelease Notes
Notes: Fixed
shell.beep()on Ubuntu.