fix: crash when calling setProgressBar on macOS #16374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
approved these changes
Jan 15, 2019
codebytere
changed the title
nornagon
reviewed
Jan 17, 2019
zcbenz
force-pushed
the
fix-progress-bar-crash
branch
from
af1b0b9
to
0fd7979
Compare
nornagon
requested changes
Jan 22, 2019
zcbenz
force-pushed
the
fix-progress-bar-crash
branch
from
0fd7979
to
627e8e8
Compare
nornagon
approved these changes
Feb 4, 2019
|
Release Notes Persisted
|
This was referenced Feb 4, 2019
|
I have automatically backported this PR to "3-1-x", please check out #16726 |
|
I have automatically backported this PR to "4-0-x", please check out #16727 |
|
I have automatically backported this PR to "5-0-x", please check out #16728 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Depending on the version of macOS and macOS SDK, the system may install a default contentView for the dock, resulting in crashes like #14008.
This PR makes the code correctly check if a progress bar has been installed in dock.
I'm not sure the exact condition to trigger the crash, and it is weird that there isn't much people seeing it. But I'm seeing it on my machine, and I can verify this PR fixes it on my machine.
Checklist
npm testpassesRelease Notes
Notes: Fix crash when calling setProgressBar on macOS