Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: emit IPC event in correct context if isolation and sandbox enabled (backport: 4-0-x) #16376

Merged
merged 2 commits into from Jan 12, 2019
Merged

fix: emit IPC event in correct context if isolation and sandbox enabled (backport: 4-0-x) #16376

merged 2 commits into from Jan 12, 2019

Commits on Jan 12, 2019

  1. fix: emit IPC event in correct context if isolation and sandbox enabled 

    IPC events were not being delivered to renderer processes when both
`contextIsolation` and `sandbox` were enabled. This is because the
`AtomSandboxedRenderFrameObserver` class was incorrectly using the
`MainWorldScriptContext`, rather than conditionally selecting the
context based on if isolation was enabled.

Fixes electron#11922
    @electron-bot
    Alex Garbutt authored and electron-bot committed Jan 12, 2019
    Copy the full SHA
    1c1ddbf View commit details
    Browse the repository at this point in the history

  2. Update tests

    @electron-bot
    Alex Garbutt authored and electron-bot committed Jan 12, 2019
    Copy the full SHA
    08a596c View commit details
    Browse the repository at this point in the history