fix: windowmenu role did not show the window list on macOS

[miniak]

Description of Change

Fix #15912 properly. The whole menu needs to have window role set, as the OS appends the window list at the end of the submenu instead of replacing a single menu item. In case of windowmenu role, we cannot change the role to window, so we need to check for windowmenu in the menu controller.

The default window menu regressed in #15930, when it switched from using window role to windowmenu.

Before

After

/cc @codebytere, @sindresorhus

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• PR title follows semantic commit guidelines
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed windowmenu role not showing the window list on macOS

[miniak]

@codebytere should we backport some version of the windowmenu fix into release branches?

[codebytere]

@miniak no, it hasn't been released yet.

[release-clerk]

Release Notes Persisted

Fixed windowmenu role not showing the window list on macOS