Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: preloads and nodeIntegration in iframes #16425

Merged
merged 11 commits into from Jan 22, 2019
Merged

feat: preloads and nodeIntegration in iframes #16425

merged 11 commits into from Jan 22, 2019

Commits on Jan 22, 2019

  1. feat: add support for node / preloads in subframes 

    This feature has delibrately been built / implemented in such a way
that it has minimum impact on existing apps / code-paths.
Without enabling the new "nodeSupportInSubFrames" option basically none of this
new code will be hit.

The things that I believe need extra scrutiny are:

* Introduction of `event.reply` for IPC events and usage of `event.reply` instead of `event.sender.send()`
* Usage of `node::FreeEnvironment(env)` when the new option is enabled in order to avoid memory leaks.  I have tested this quite a bit and haven't managed to cause a crash but it is still feature flagged behind the "nodeSupportInSubFrames" flag to avoid potential impact.

Closes #10569
Closes #10401
Closes #11868
Closes #12505
Closes #14035
    @MarshallOfSound
    MarshallOfSound committed Jan 22, 2019
    1
    Copy the full SHA
    aadee6c View commit details
    Browse the repository at this point in the history

  2. feat: add support preloads in subframes for sandboxed renderers

    @MarshallOfSound
    MarshallOfSound committed Jan 22, 2019
    Copy the full SHA
    939dd8d View commit details
    Browse the repository at this point in the history

  3. spec: add tests for new nodeSupportInSubFrames option

    @MarshallOfSound
    MarshallOfSound committed Jan 22, 2019
    Copy the full SHA
    94e0944 View commit details
    Browse the repository at this point in the history

  4. spec: fix specs for .reply and ._replyInternal for internal messages

    @MarshallOfSound
    MarshallOfSound committed Jan 22, 2019
    Copy the full SHA
    aa18611 View commit details
    Browse the repository at this point in the history

  5. chore: revert change to use flag instead of environment set size

    @MarshallOfSound
    MarshallOfSound committed Jan 22, 2019
    Copy the full SHA
    44e4943 View commit details
    Browse the repository at this point in the history

  6. chore: clean up subframe impl

    @MarshallOfSound
    MarshallOfSound committed Jan 22, 2019
    Copy the full SHA
    5842618 View commit details
    Browse the repository at this point in the history

  7. chore: apply suggestions from code review 

    Co-Authored-By: MarshallOfSound <samuel.r.attard@gmail.com>
    @nornagon @MarshallOfSound
    nornagon and MarshallOfSound committed Jan 22, 2019
    Copy the full SHA
    eaa44c5 View commit details
    Browse the repository at this point in the history

  8. chore: clean up reply usage

    @MarshallOfSound
    MarshallOfSound committed Jan 22, 2019
    Copy the full SHA
    bb2926e View commit details
    Browse the repository at this point in the history

  9. chore: fix TS docs generation

    @MarshallOfSound
    MarshallOfSound committed Jan 22, 2019
    Copy the full SHA
    64310cd View commit details
    Browse the repository at this point in the history

  10. chore: cleanup after rebase

    @MarshallOfSound
    MarshallOfSound committed Jan 22, 2019
    Copy the full SHA
    ad0f072 View commit details
    Browse the repository at this point in the history

  11. chore: rename wrap to add in event fns

    @MarshallOfSound
    MarshallOfSound committed Jan 22, 2019
    Copy the full SHA
    cd00a36 View commit details
    Browse the repository at this point in the history