docs: fix web-request.md listener signatures in electron.d.ts #16485

miniak · 2019-01-22T13:34:06Z

Fixes listener being generated as Function for onBeforeSendHeaders and onHeadersReceived.

PR description included and stakeholders cc'd
npm test passes
relevant documentation is changed or added
PR title follows semantic commit guidelines
PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Notes: Fixed onBeforeSendHeaders / onSendHeaders listener signatures in electron.d.ts.

release-clerk · 2019-01-22T16:46:44Z

Release Notes Persisted

Fixed onBeforeSendHeaders / onSendHeaders listener signatures in electron.d.ts.

trop · 2019-01-22T16:47:20Z

I have automatically backported this PR to "4-0-x", please check out #16487

trop · 2019-01-22T16:47:25Z

I have automatically backported this PR to "3-1-x", please check out #16488

miniak requested a review from a team January 22, 2019 13:34

docs: fix web-request.md listener signatures in electron.d.ts

e214ae1

miniak force-pushed the miburda/web-request-docs branch from 4162685 to e214ae1 Compare January 22, 2019 13:37

miniak self-assigned this Jan 22, 2019

miniak added the 4-2-x label Jan 22, 2019

alexeykuzmin approved these changes Jan 22, 2019

View reviewed changes

miniak added target/4-0-x and removed 4-2-x labels Jan 22, 2019

ppontes approved these changes Jan 22, 2019

View reviewed changes

MarshallOfSound approved these changes Jan 22, 2019

View reviewed changes

BinaryMuse merged commit dbc5f67 into master Jan 22, 2019

BinaryMuse deleted the miburda/web-request-docs branch January 22, 2019 16:46

trop bot mentioned this pull request Jan 22, 2019

docs: fix web-request.md listener signatures in electron.d.ts (backport: 4-0-x) #16487

Merged

trop bot removed the target/4-0-x label Jan 22, 2019

trop bot mentioned this pull request Jan 22, 2019

docs: fix web-request.md listener signatures in electron.d.ts (backport: 3-1-x) #16488

Merged

trop bot added the in-flight/4-0-x label Jan 22, 2019

trop bot added in-flight/3-1-x and removed target/3-1-x labels Jan 22, 2019

sofianguy added this to Fixed in 3.1.2 in 3.1.x Jan 25, 2019

Provide feedback