refactor: pass internal flag via IPC message struct for consistency #16490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
approved these changes
Jan 23, 2019
MarshallOfSound
approved these changes
Jan 23, 2019
miniak
force-pushed
the
miniak/ipc-message-refactoring
branch
from
d9c32b3
to
d06663d
Compare
miniak
force-pushed
the
miniak/ipc-message-refactoring
branch
from
d06663d
to
2d0d5e4
Compare
codebytere
approved these changes
Jan 23, 2019
|
No Release Notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Makes the code a bit more robust. The event name
ipc-internal-messagewas duplicated 2x in native code and 2x in JS code before for example.Follow up to #13940 and #16468.
Note: I am looking into implementing
ipcRenderer.sendToHost()in native code to get better performance, similar toipcRenderer.sendTo()(#14285). This will be done in a separate PR.Checklist
npm testpasses/cc @MarshallOfSound
Release Notes
Notes: no-notes