fix: enable and update osr #16517

codebytere · 2019-01-23T19:55:00Z

Closes #16502.

Re-enable osr following last two Chromium upgrades.

PR description included and stakeholders cc'd
npm test passes
PR title follows semantic commit guidelines
PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Notes: Fixed and re-enabled osr after it was turned off following updates to Chromium 71/72.

release-clerk · 2019-01-30T17:33:35Z

Release Notes Persisted

Fixed and re-enabled osr after it was turned off following updates to Chromium 71/72.

trop · 2019-01-30T17:33:50Z

I have automatically backported this PR to "5-0-x", please check out #16616

brenca and others added 3 commits January 23, 2019 18:47

fix: enable OSR

af4c386

fix some macos errors

f2c42ac

fix client reset not in guard

afdec54

codebytere requested a review from a team January 23, 2019 19:55

brenca changed the title ~~fix: enable and update osr~~ [WIP] fix: enable and update osr Jan 24, 2019

fix things not rendering on mac

dc32d20

brenca changed the title ~~[WIP] fix: enable and update osr~~ fix: enable and update osr Jan 28, 2019

brenca approved these changes Jan 28, 2019

View reviewed changes

alexeykuzmin approved these changes Jan 30, 2019

View reviewed changes

codebytere added the target/5-0-x label Jan 30, 2019

codebytere merged commit c7677b2 into master Jan 30, 2019

trop bot mentioned this pull request Jan 30, 2019

fix: enable and update osr (backport: 5-0-x) #16616

Merged

trop bot added in-flight/5-0-x and removed target/5-0-x labels Jan 30, 2019

codebytere deleted the brenca/enable-osr branch January 30, 2019 17:33

sofianguy added the app-feedback-program label Jan 30, 2019

trop bot added merged/5-0-x and removed in-flight/5-0-x labels Jan 30, 2019

sofianguy added this to 5.0.0-beta.2 in 5.0.x Feb 4, 2019

Provide feedback