fix: correctly destroy spellcheck client #16526

nitsakh · 2019-01-24T07:02:46Z

Backport of #16448.

PR description included and stakeholders cc'd
npm test passes
tests are changed or added
relevant documentation is changed or added
PR title follows semantic commit guidelines
PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Notes: Fixed memory leak caused by webFrame.setSpellCheckProvider.

release-clerk · 2019-01-29T23:59:02Z

Release Notes Persisted

Fixed memory leak caused by webFrame.setSpellCheckProvider.

nitsakh added 2 commits January 23, 2019 22:59

fix: Destroy spellcheck client

1845894

Address review comments

dabf332

nitsakh requested a review from a team January 24, 2019 07:02

deepak1556 approved these changes Jan 24, 2019

View reviewed changes

codebytere changed the title ~~Fix spell leak 3 1~~ fix: correctly destroy spellcheck client Jan 24, 2019

codebytere added backport This is a backport PR 3-1-x labels Jan 24, 2019

codebytere approved these changes Jan 29, 2019

View reviewed changes

codebytere merged commit ce33169 into 3-1-x Jan 29, 2019

codebytere deleted the fix-spell-leak-3-1 branch January 29, 2019 23:59

Provide feedback