fix: execute session preload scripts in sandboxed renderers #16538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniak
force-pushed
the
miniak/sandbox-session-preloads
branch
2 times, most recently
from
2d1e62c
to
b0a132a
Compare
miniak
force-pushed
the
miniak/sandbox-session-preloads
branch
from
b0a132a
to
b8aa595
Compare
MarshallOfSound
approved these changes
Jan 28, 2019
zcbenz
approved these changes
Jan 29, 2019
|
Release Notes Persisted
|
|
I have automatically backported this PR to "5-0-x", please check out #16578 |
|
/trop run backport-to 4-1-x |
|
The backport process for this PR has been manually initiated, |
|
I was unable to backport this PR to "4-1-x" cleanly; |
5 tasks
|
A maintainer has manually backported this PR to "4-1-x", please check out #17875 |
1 similar comment
|
A maintainer has manually backported this PR to "4-1-x", please check out #17875 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The code to execute session preload scripts in sandboxed renderers was missing.
/cc @MarshallOfSound, @zcbenz, @tarruda
Checklist
npm testpassesRelease Notes
Notes: Fixed session preload scripts not being executed in sandboxed renderers.