Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: expose aes-cfb ciphers from boringssl #16573

Merged
merged 1 commit into from Jan 30, 2019
Merged

fix: expose aes-cfb ciphers from boringssl #16573

merged 1 commit into from Jan 30, 2019

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Jan 28, 2019 •
edited

Ref #16195
Closes #16187

Checklist

Release Notes

Notes: Restored support for AES-CFB cipher, which was lost when switching from OpenSSL to BoringSSL.

@nornagon nornagon requested review from codebytere, ryzokuken and a team January 28, 2019 21:41
@nornagon nornagon mentioned this pull request Jan 29, 2019
Closed
ryzokuken
ryzokuken approved these changes Jan 30, 2019
View reviewed changes
Copy link

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this.

Unlike RIPEMD160, AES-*-CFB is a family of ciphers I can actually understand being used in the real world.

@nornagon
Copy link
Member Author

CI failures unrelated; merging.

@nornagon nornagon merged commit 9ed89ac into master Jan 30, 2019
@release-clerk
Copy link

release-clerk bot commented Jan 30, 2019

Release Notes Persisted

Restored support for AES-CFB cipher, which was lost when switching from OpenSSL to BoringSSL.

@nornagon
Copy link
Member Author

/trop run backport

@trop
Copy link
Contributor

trop bot commented Jan 30, 2019

The backport process for this PR has been manually initiated, here we go! :D

This was referenced Jan 30, 2019
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Jan 30, 2019

I have automatically backported this PR to "4-0-x", please check out #16617

@trop
Copy link
Contributor

trop bot commented Jan 30, 2019

I have automatically backported this PR to "5-0-x", please check out #16618

@nornagon nornagon deleted the aes-cfb branch January 30, 2019 18:37
@sofianguy sofianguy added this to 5.0.0-beta.2 in 5.0.x Feb 4, 2019
@gnarea gnarea mentioned this pull request Nov 17, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@ryzokuken ryzokuken ryzokuken approved these changes

@codebytere codebytere Awaiting requested review from codebytere

Assignees
No one assigned
Labels
None yet
Projects
No open projects
5.0.x
Fixed in 5.0.0-beta.2
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nornagon @MarshallOfSound @ryzokuken