ci: Run Windows Electron tests first to show those failures first #16610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckerr
approved these changes
Jan 30, 2019
alexeykuzmin
approved these changes
Jan 30, 2019
4 tasks
added 2 commits
January 31, 2019 07:08
jkleinsc
force-pushed
the
fix-32bit-windows
branch
from
3766bf6
to
5e24e57
Compare
|
Release Notes Persisted no-notes |
|
I have automatically backported this PR to "5-0-x", please check out #16655 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The windows 32-bit CI build is stalling on the Electron tests, so this PR reorganizes our CI tests to run electron tests before verifying ffmpeg and mksnapshot. Also, this PR enables logging on Appveyor (Windows) CI to give better insight into failing tests.
Description of Change
Checklist
npm testpassesRelease Notes
Notes: no-notes