feat: promisify contentTracing.getCategories() #16624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
changed the title
ckerr
approved these changes
Feb 1, 2019
codebytere
force-pushed
the
getcategories-bp
branch
from
8f22555
to
a6fd447
Compare
|
This shouldn't be merged until it's rebased on #16643 |
codebytere
force-pushed
the
getcategories-bp
branch
from
a6fd447
to
9b0afd6
Compare
* feat: promisify contentTracing.getCategories() * deprecate contentTracing/getCategories
codebytere
force-pushed
the
getcategories-bp
branch
from
9b0afd6
to
7c83937
Compare
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Backport of #16583.
cc @ckerr
Checklist
npm testpassesRelease Notes
Notes: Converted
contentTracing.getCategories()to return a promise instead taking a callback.