Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move webFrame scheme privilege methods to main process #16625

Merged
merged 2 commits into from Jan 30, 2019

Conversation

nitsakh
Copy link
Contributor

@nitsakh nitsakh commented Jan 30, 2019

Description of Change

Backport of #16416 and #16601.

BREAKING CHANGE

Checklist

Release Notes

Notes: Moved webFrame custom scheme APIs to browser process under protocol

* chore: deprecate webFrame.registerURLSchemeAsPrivileged

* Add register schemes protocol api

* update branch to enable browser process API

* Revert deprecation changes

* Fetch API support

* Updated api to take an array, still working on tests

* Update tests

* Remove web frame API

* Minor changes

* update scheme registrations on browser and renderer process

* fix: enable ses.getBlobData spec

* Update breaking changes doc
* fix: update docs for protocol API

* upddate source for new attribute name

* update electron-typescript-definitions package
@nitsakh nitsakh requested review from a team January 30, 2019 20:57
@trop trop bot mentioned this pull request Jan 30, 2019
6 tasks
@nitsakh nitsakh changed the base branch from master to 5-0-x January 30, 2019 20:57
@nitsakh nitsakh changed the title Schemes api 5 chore: Move webFrame scheme privilege methods to main process Jan 30, 2019
@MarshallOfSound MarshallOfSound merged commit d6612d2 into 5-0-x Jan 30, 2019
@release-clerk
Copy link

release-clerk bot commented Jan 30, 2019

Release Notes Persisted

Moved webFrame custom scheme APIs to browser process under protocol

@MarshallOfSound MarshallOfSound deleted the schemes-api-5 branch January 30, 2019 22:57
@nornagon
Copy link
Member

This is a breaking change yes? I've added BREAKING CHANGE to the PR description, remove it if I'm wrong.

samuelthomas2774 added a commit to samuelthomas2774/BetterDiscordApp that referenced this pull request Apr 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants