Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix typo in AtomDownloadManagerDelegate::OnDownloadSaveDialogDone #16646

Merged
merged 1 commit into from Jan 31, 2019

Conversation

poiru
Copy link
Contributor

@poiru poiru commented Jan 31, 2019

I believe the existing code was fine, but better be safe than sorry.
This typo was introduced in #16612.

Notes: no-notes

@poiru poiru requested review from a team and zcbenz January 31, 2019 07:54
poiru added a commit that referenced this pull request Jan 31, 2019
Backport of #16612 and #16646

Notes: Fix broken save dialog on macOS for `<a>` downloads
poiru added a commit that referenced this pull request Jan 31, 2019
Backport of #16612 and #16646

Notes: Fix broken save dialog on macOS for `<a>` downloads
I believe the existing code was fine, but better be safe than sorry.
This typo was introduced in #16612.
@trop
Copy link
Contributor

trop bot commented Jan 31, 2019

A maintainer has manually backported this PR to "4-0-x", please check out #16647

@zcbenz zcbenz merged commit 6c77c22 into master Jan 31, 2019
@release-clerk
Copy link

release-clerk bot commented Jan 31, 2019

No Release Notes

@trop
Copy link
Contributor

trop bot commented Jan 31, 2019

I have automatically backported this PR to "5-0-x", please check out #16650

@trop
Copy link
Contributor

trop bot commented Feb 4, 2019

A maintainer has manually backported this PR to "4-0-x", please check out #16647

MarshallOfSound pushed a commit that referenced this pull request Feb 4, 2019
)

Backport of #16612 and #16646

Notes: Fix broken save dialog on macOS for `<a>` downloads
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants