ci: Move MacOS CI to CircleCI (5-0-x) #16656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
approved these changes
Jan 31, 2019
There was a problem hiding this comment.
lgtm
We may want to rebase this after #16662 lands, though!
jkleinsc
force-pushed
the
move-macci-to-circleci
branch
from
10f322d
to
9db137b
Compare
jkleinsc
force-pushed
the
move-macci-to-circleci
branch
from
9db137b
to
6f0993c
Compare
|
Merging as Windows CI results are unrelated to this PR. |
|
Release Notes Persisted no-notes |
codebytere
added a commit
that referenced
this pull request
Feb 3, 2019
This reverts commit 16dfa56.
|
@jkleinsc i had to revert this: it died super aggressively: https://papertrailapp.com/systems/electron-sudowoodo/events?focus=1028574252234457122 We've never tested this on releae builds, so i think our next move here may be to test this on a |
jkleinsc
pushed a commit
that referenced
this pull request
Feb 11, 2019
This reverts commit 3dcb7cf.
jkleinsc
pushed a commit
that referenced
this pull request
Feb 11, 2019
codebytere
pushed a commit
that referenced
this pull request
Feb 13, 2019
* ci: Put back changes to build mac on CircleCI (#16656) This reverts commit 3dcb7cf. * ci: make macOS CI faster (#16766) * ci: cache brew update result * ci: checkout and sync the macOS build on a linux machine for speed * ci: set MAS_BUILD=true on mas builds (#16824) * build: remove non-arm vstsJobs (#16793) * ci: fix binaries for chromedriver build on macOS (#16893)
jkleinsc
pushed a commit
that referenced
this pull request
Feb 13, 2019
* ci: build mac on CircleCI (#16656) * ci: make macOS CI faster (#16766) * ci: cache brew update result * ci: checkout and sync the macOS build on a linux machine for speed * ci: set MAS_BUILD=true on mas builds (#16824) * build: remove non-arm vstsJobs (#16793) * ci: fix binaries for chromedriver build on macOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Backport of #16552 to 5-0-x. Moves MacOS CI to CircleCI
Checklist
npm testpassesRelease Notes
Notes: no-notes