Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shutdown after message loop is ready #16671

Merged
merged 1 commit into from Feb 1, 2019
Merged

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented Feb 1, 2019

Description of Change

When app.quit() is called while the message loop is not fully started, do not shutdown until message loop is ready.

Quitting too early would break Chromium's shutdown code, and leave a few defunct processes behind.

Close #16632.

Checklist

Release Notes

Notes: Fix defunct processes after quitting.

@zcbenz zcbenz added the 5-0-x label Feb 1, 2019
@zcbenz zcbenz requested a review from a team February 1, 2019 07:29
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The failing CI was a release test that shouldn't have run for this PR - so this PR can be merged.

@jkleinsc jkleinsc merged commit 31c7ed9 into master Feb 1, 2019
@release-clerk
Copy link

release-clerk bot commented Feb 1, 2019

Release Notes Persisted

Fix defunct processes after quitting.

@jkleinsc
Copy link
Contributor

jkleinsc commented Feb 1, 2019

/trop run backport-to 5-0-x

@trop
Copy link
Contributor

trop bot commented Feb 1, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "5-0-x" here we go! :D

@trop
Copy link
Contributor

trop bot commented Feb 1, 2019

I have automatically backported this PR to "5-0-x", please check out #16672

@trop trop bot added the in-flight/5-0-x label Feb 1, 2019
@jkleinsc jkleinsc deleted the quit-until-ready branch February 1, 2019 15:29
@deepak1556
Copy link
Member

@zcbenz should this be backported to 4-0-x as well, where the changes originated from f5eaa97#diff-735da1d7bca6fa4542f4eea75dc6595d

@zcbenz
Copy link
Member Author

zcbenz commented Feb 2, 2019

@deepak1556 4-0-x is working fine so I think we can leave it be. It is required in 5-0-x because CI is broken there.

@sofianguy sofianguy added this to 5.0.0-beta.2 in 5.0.x Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
5.0.x
Fixed in 5.0.0-beta.2
Development

Successfully merging this pull request may close these issues.

None yet

3 participants