refactor: implement Chrome Extension APIs without the remote module #16686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
miniak
force-pushed
the
miniak/chrome-extension
branch
5 times, most recently
from
a7e7733
to
f39c195
Compare
alexeykuzmin
approved these changes
Feb 1, 2019
miniak
force-pushed
the
miniak/chrome-extension
branch
from
f39c195
to
9946329
Compare
nornagon
requested changes
Feb 1, 2019
nornagon
reviewed
Feb 2, 2019
miniak
force-pushed
the
miniak/chrome-extension
branch
2 times, most recently
from
42df030
to
73d95a7
Compare
zcbenz
approved these changes
Feb 4, 2019
nornagon
approved these changes
Feb 4, 2019
miniak
force-pushed
the
miniak/chrome-extension
branch
2 times, most recently
from
130c867
to
7e7c1f0
Compare
3 tasks
|
There is some issue with tests failing on MAS builds. I have created a separated smaller PR with the first part of the refactoring to land it separately #16739 |
miniak
force-pushed
the
miniak/chrome-extension
branch
from
7e7c1f0
to
3216a60
Compare
5 tasks
miniak
force-pushed
the
miniak/chrome-extension
branch
from
3216a60
to
7f3fc41
Compare
|
@zcbenz can you please merge? |
|
No Release Notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
remotemodule in Chrome Extension API implementation (storage.js).Checklist
npm testpassesRelease Notes
Notes: no-notes