feat: allow Menu.buildFromTemplate() to accept MenuItems #16697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
reviewed
Feb 3, 2019
miniak
approved these changes
Feb 6, 2019
codebytere
changed the title
MarshallOfSound
approved these changes
Feb 6, 2019
|
Release Notes Persisted
|
|
I have automatically backported this PR to "5-0-x", please check out #16783 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Resolves #16645.
Augment
Menu.buildFromTemplate()to allow for MenuItem instances to be passed in either in place of or alongside plain objects.Checklist
npm testpassesRelease Notes
Notes: Updated
Menu.buildFromTemplate()to allow it to acceptMenuItems in addition to plain objects.