Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: deprecate ServiceWorker APIs #16732

Merged
merged 1 commit into from Feb 5, 2019
Merged

refactor: deprecate ServiceWorker APIs #16732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/browser/api/web-contents.js
View file
Open in desktop
Expand Up @@ -379,6 +379,8 @@ WebContents.prototype._init = function () {
this.setMaxListeners(0)

this.capturePage = deprecate.promisify(this.capturePage)
this.hasServiceWorker = deprecate.function(this.hasServiceWorker)
this.unregisterServiceWorker = deprecate.function(this.unregisterServiceWorker)

// Dispatch IPC messages to the ipc module.
this.on('-ipc-message', function (event, [channel, ...args]) {
Expand Down
10 changes: 10 additions & 0 deletions lib/common/api/deprecate.js
View file
Open in desktop
Expand Up @@ -69,6 +69,16 @@ const deprecate = {
})
},

function: (fn, newName) => {
// if newName is left blank, a removal warning will be displayed
const warn = warnOnce(fn.name, newName)

return function () {
if (!process.noDeprecation) warn()
return fn.apply(this, arguments)
}
},

promisify: (fn) => {
const fnName = fn.name || 'function'
const oldName = `${fnName} with callbacks`
Expand Down