Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: migration guide for register{StandardSchemes => SchemesAsPrivileged} #16762

Merged
merged 5 commits into from Feb 12, 2019

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Feb 5, 2019

Description of Change

Added migration guide for protocol.registerStandardSchemes, webFrame.registerURLSchemeAs* and protocol.registerServiceWorkerSchemes.

cc @nitsakh

Checklist

Release Notes

Notes: no-notes

@nornagon nornagon requested a review from a team February 5, 2019 23:48
MarshallOfSound and others added 3 commits February 6, 2019 14:46
Co-Authored-By: nornagon <nornagon@nornagon.net>
Co-Authored-By: nornagon <nornagon@nornagon.net>
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, just a small nit around wording.

docs/api/protocol.md Outdated Show resolved Hide resolved
Co-Authored-By: nornagon <nornagon@nornagon.net>
@jkleinsc
Copy link
Contributor

Merging as CI failure isn't related to doc change.

@jkleinsc jkleinsc merged commit 5a44cc5 into master Feb 12, 2019
@release-clerk
Copy link

release-clerk bot commented Feb 12, 2019

Release Notes Persisted

no-notes

@jkleinsc jkleinsc deleted the nornagon-patch-2 branch February 12, 2019 14:32
@deepak1556 deepak1556 mentioned this pull request Feb 12, 2019
6 tasks
MarshallOfSound added a commit that referenced this pull request Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants