Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make getUserMedia APIs work again on C72+ #16763

Merged
merged 2 commits into from Feb 6, 2019
Merged

Conversation

brenca
Copy link
Contributor

@brenca brenca commented Feb 6, 2019

Description of Change

Fixes #16508
Fixes #16513

Pretty much what the title says, got the fix from https://bitbucket.org/chromiumembedded/cef/commits/e94b3e2478491e5867e970687afcd53323a6fbe8

Checklist

Release Notes

Notes:

Fixed getUserMedia on v5.0.x and up.

@brenca brenca added the 5-0-x label Feb 6, 2019
@brenca brenca requested review from deepak1556 and a team February 6, 2019 01:09
@MarshallOfSound
Copy link
Member

@brenca Not required for this PR but do you know if it's possible to write a test to check that the API isn't Completely Broken during an upgrade. E.g. expect(mediaStream).to.not.be.a.black.square.of.nothing()?

@deepak1556
Copy link
Member

Upstream fix: https://chromium-review.googlesource.com/c/chromium/src/+/1049931/

Not sure why this wasn't part of //content client, could have benefitted all embedders.

Fixes #16508
Fixes #16513

Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@deepak1556
Copy link
Member

deepak1556 commented Feb 6, 2019

Might need dependency on //services/video_capture/public/mojom:constants.

@codebytere codebytere merged commit ff461d9 into master Feb 6, 2019
@release-clerk
Copy link

release-clerk bot commented Feb 6, 2019

Release Notes Persisted

@trop
Copy link
Contributor

trop bot commented Feb 6, 2019

I have automatically backported this PR to "5-0-x", please check out #16768

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants