New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make getUserMedia APIs work again on C72+ #16763
Conversation
@brenca Not required for this PR but do you know if it's possible to write a test to check that the API isn't Completely Broken during an upgrade. E.g. |
Upstream fix: https://chromium-review.googlesource.com/c/chromium/src/+/1049931/ Not sure why this wasn't part of //content client, could have benefitted all embedders. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
|
Release Notes Persisted |
I have automatically backported this PR to "5-0-x", please check out #16768 |
Description of Change
Fixes #16508
Fixes #16513
Pretty much what the title says, got the fix from https://bitbucket.org/chromiumembedded/cef/commits/e94b3e2478491e5867e970687afcd53323a6fbe8
Checklist
npm test
passesRelease Notes
Notes:
Fixed getUserMedia on v5.0.x and up.