Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:webframe spellcheck client leak for sandbox mode #16765

Closed
wants to merge 2 commits into from

Conversation

nitsakh
Copy link
Contributor

@nitsakh nitsakh commented Feb 6, 2019

Description of Change

RenderFrameObserver OnDestruct method is only called in non sandbox mode. So spellcheck client was destroyed only in non sandbox mode.
This fixes that and moves the spellcheck client destruction to WillReleaseScriptContext which will be called in both sandbox and non-sandbox mode.

Checklist

Release Notes

Notes: Fixed webframe spellcheck provider memory leak for sandbox mode

@nitsakh nitsakh requested a review from a team February 6, 2019 01:16
@nitsakh nitsakh changed the title [WIP] fix:webframe spellcheck client leak for sandbox mode fix:webframe spellcheck client leak for sandbox mode Feb 6, 2019
@zcbenz
Copy link
Member

zcbenz commented Feb 6, 2019

I have created #16770 based on the changes here, which should hopefully fix most leak sources.

@nitsakh
Copy link
Contributor Author

nitsakh commented Feb 7, 2019

Thanks! I'll close this one then.

@nitsakh nitsakh closed this Feb 7, 2019
@codebytere codebytere deleted the better-fix-spell-leak branch August 6, 2019 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants