fix: enable property having no effect on submenus #16835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
approved these changes
Feb 8, 2019
codebytere
force-pushed
the
fix-disable-submenu
branch
from
7496416
to
64b7cc3
Compare
|
Release Notes Persisted
|
This was referenced Feb 9, 2019
|
I have automatically backported this PR to "4-0-x", please check out #16857 |
|
I have automatically backported this PR to "5-0-x", please check out #16858 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Resolves #16821.
We need to specifically check that the submenu top-level item has been enabled on macOS, as it's not validated by
validateUserInterfaceItem.Before Change:
After Change:
Contributors guide: https://github.com/electron/electron/blob/master/CONTRIBUTING.md
-->
Checklist
npm testpassesRelease Notes
Notes: Fixed the
enableproperty having no effect for top-level submenuMenuItems.