Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable Chromium sandbox v2 in MAS builds #16920

Merged
merged 1 commit into from Feb 14, 2019
Merged

fix: disable Chromium sandbox v2 in MAS builds #16920

merged 1 commit into from Feb 14, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Feb 13, 2019 •
edited

Description of Change

Fixes #16919

/cc @nornagon

Checklist

Release Notes

Notes: Fixed Chromium sandbox v2 related crashes in MAS builds.

@miniak miniak requested review from nornagon and a team February 13, 2019 01:31
@miniak miniak mentioned this pull request Feb 13, 2019
Merged
4 tasks
@miniak miniak self-assigned this Feb 13, 2019
@deepak1556
Copy link
Member

Would it also be better to guard "//sandbox/mac:seatbelt", "//sandbox/mac:seatbelt_extension",
targets in upstream code behind !is_mas_build and simplify the patch in mas_no_private_api.patch. That way we are guaranteed to remove v2 sandbox code that may appear in future.

@miniak
Copy link
Contributor Author

miniak commented Feb 13, 2019

@deepak1556 should we do that here or in a follow up PR?

@miniak miniak changed the title fix: disable Chromium v2 sandbox in MAS builds fix: disable Chromium sandbox v2 in MAS builds Feb 13, 2019
@deepak1556
Copy link
Member

It can be a follow up, this PR addresses the immediate issue 👍

@miniak
Copy link
Contributor Author

miniak commented Feb 13, 2019

It can be a follow up, this PR addresses the immediate issue 👍

@deepak1556 can you please approve in that case?

@miniak
Copy link
Contributor Author

miniak commented Feb 13, 2019

@nornagon are you ok with the fix?

nornagon
nornagon reviewed Feb 13, 2019
View reviewed changes
atom/app/atom_main.cc Outdated Show resolved Hide resolved
@nornagon nornagon merged commit e769b86 into master Feb 14, 2019
@release-clerk
Copy link

release-clerk bot commented Feb 14, 2019

Release Notes Persisted

Fixed Chromium sandbox v2 related crashes in MAS builds.

@nornagon nornagon deleted the miniak/mas-disable-sandbox branch February 14, 2019 17:48
@trop trop bot mentioned this pull request Feb 14, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Feb 14, 2019

I have automatically backported this PR to "5-0-x", please check out #16969

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees

@miniak miniak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miniak @deepak1556 @nornagon