fix: carry through arguments in webContents.print() #17052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we try to unstick this code review. Looks like the built-test failure might be related to something else? |
codebytere
approved these changes
Feb 25, 2019
There was a problem hiding this comment.
The fixed rest arguments look good to me, and so does the initialization of silent.
cc @deepak1556 for a second confirmation since you've spent more time in print-related code?
|
Release Notes Persisted
|
|
Congrats on merging your first pull request! 🎉🎉🎉 |
This was referenced Feb 25, 2019
|
I have automatically backported this PR to "4-0-x", please check out #17116 |
|
I have automatically backported this PR to "5-0-x", please check out #17117 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix for #16792
webContents.print()doesn't deserialize arguments correctly, and doesn't initialize thesilentargument correctly. This had the side-effect ofwebContents.print()only sometimes working and always ignoring passed arguments.Checklist
npm testpassesRelease Notes
Notes: Fixed
webContents.print()not working correctly.